commit 03db67b322d76d717be17a87e777c91dd0fdd3ac
author Bill Fenner <fenner@gmail.com> Tue Aug 12 23:55:07 2014 -0400
committer Bill Fenner <fenner@gmail.com> Tue Aug 12 23:55:07 2014 -0400
tree e01807ec6b2c9e41a641d77c7ff92b9e38e70ac2
parent 8ae78da391d5b6b61cc2516eb1a6520b0dabb6bf

If sdl_alen is too long for the static buffer, call it incomplete instead of overrunning the buffer

agent/mibgroup/ip-mib/data_access/arp_sysctl.c

diff --git a/agent/mibgroup/ip-mib/data_access/arp_sysctl.c b/agent/mibgroup/ip-mib/data_access/arp_sysctl.c
index 9816664..24e9cda 100644
--- a/agent/mibgroup/ip-mib/data_access/arp_sysctl.c
+++ b/agent/mibgroup/ip-mib/data_access/arp_sysctl.c
@@ -190,7 +190,8 @@
 
         /* HW Address */
         entry->arp_physaddress_len = 6;
-        if (0 < sdl->sdl_alen) {
+        if (0 < sdl->sdl_alen &&
+            sdl->sdl_alen <= NETSNMP_ACCESS_ARP_PHYSADDR_BUF_SIZE) {
             memcpy(entry->arp_physaddress, LLADDR(sdl), sdl->sdl_alen);
             /* Process status */
             /* XXX: setting this value for all states is wrong. */
@@ -298,7 +299,8 @@
 
         /* HW Address */
         entry->arp_physaddress_len = sdl->sdl_alen;
-        if (0 < sdl->sdl_alen) {
+        if (0 < sdl->sdl_alen &&
+            sdl->sdl_alen <= NETSNMP_ACCESS_ARP_PHYSADDR_BUF_SIZE) {
             memcpy(entry->arp_physaddress, LLADDR(sdl), sdl->sdl_alen);
             /* Process status */
             /* XXX: setting this value for all states is wrong. */