conman: always initialize WPA control interface on startup.
Previously, conman only initialized the WPA control interface if the
client interface was not already up. In the case of a provisioned
device, the client interface will be started at boot by "wifi restore".
As a result, conman does not initialize the WPA control interface. When
processing the command file, conman will incorrectly think the client
interface is down, clear the routes, and run "wifi setclient". Because
the WiFi configuration has not changed, "wifi setclient" is a no-op and
dhclient is not restarted. This results in a state where the client
interface is associated but there are no routes since no new DHCP leases
were received.
Change-Id: I8c66d626e9566d1526cca018332d44489ec66a1e
diff --git a/conman/connection_manager.py b/conman/connection_manager.py
index f43ee8d..fb01acf 100755
--- a/conman/connection_manager.py
+++ b/conman/connection_manager.py
@@ -312,13 +312,13 @@
# the wpa_supplicant link is up, attempt to attach to the wpa_supplicant
# control interface.
for wifi in self.wifi:
+ wifi_up = self.is_interface_up(wifi.name)
if not os.path.exists(
os.path.join(self._interface_status_dir, wifi.name)):
- wifi_up = self.is_interface_up(wifi.name)
self.ifplugd_action(wifi.name, wifi_up)
- if wifi_up:
- wifi.status.attached_to_wpa_supplicant = wifi.attach_wpa_control(
- self._wpa_control_interface)
+ if wifi_up:
+ wifi.status.attached_to_wpa_supplicant = wifi.attach_wpa_control(
+ self._wpa_control_interface)
for path, prefix in ((self._tmp_dir, self.GATEWAY_FILE_PREFIX),
(self._tmp_dir, self.SUBNET_FILE_PREFIX),
