commit 66388355d6280c5f7ad11f7830982927130be3eb
author Avery Pennarun <apenwarr@gmail.com> Thu Nov 29 23:38:44 2012 -0500
committer Avery Pennarun <apenwarr@gmail.com> Mon Dec 10 02:03:34 2012 -0500
tree b51fc1b03a61ad22c408300d7bf3b465e08f9d87
parent 5d9786ebb1b3c21ee4ea935fb106914b31ddcfba

Properly handle NULL columns in aggregation functions.

In particular, sum(1, NULL, 2) should be 3, where it was NaN.

render.js

diff --git a/render.js b/render.js
index f9504c9..3d3ba34 100644
--- a/render.js
+++ b/render.js
@@ -245,7 +245,8 @@
   },
 
   sum: function(l) {
-    var acc = 0;
+    var acc;
+    if (l.length) acc = 0;
     for (var i in l) {
       acc += parseFloat(l[i]);
     }
@@ -295,7 +296,9 @@
       var outcoli = key.length + parseInt(valuei);
       var cell = row[incoli];
       if (!orow[outcoli]) orow[outcoli] = [];
-      orow[outcoli].push(cell);
+      if (cell != null) {
+	orow[outcoli].push(cell);
+      }
     }
   };