commit 7a4d6f2b1708b24780685c82c566e64f5ab844c1
author Jean-Francois Thibert <jfthibert@google.com> Wed Jul 30 11:04:35 2014 -0400
committer Jean-Francois Thibert <jfthibert@google.com> Wed Jul 30 11:04:35 2014 -0400
tree 8d6e34203b60c90f5d8dec8322f4a4f58b8d0934
parent ea1102a5013ab3a6e33a71ddd3657f7b4df553e5

Fix buffer overflow in dial_data.c (b/16674612)

Change-Id: I0064b2c6577da0d1b67daa7ec5b9c24e153e2653

src/server/dial_data.c

diff --git a/src/server/dial_data.c b/src/server/dial_data.c
index 9ed256b..a02b99f 100644
--- a/src/server/dial_data.c
+++ b/src/server/dial_data.c
@@ -43,10 +43,8 @@
     char value[256];
     while (fscanf(f, "%255s %255s\n", key, value) != EOF) {
         DIALData *newNode = (DIALData *) malloc(sizeof(DIALData));
-        newNode->key = (char *) malloc(strlen(key));
-        strcpy(newNode->key, key);
-        newNode->value = (char *) malloc(strlen(value));
-        strcpy(newNode->value, value);
+        newNode->key = strdup(key);
+        newNode->value = strdup(value);
         newNode->next = result;
         result = newNode;
     }