[RFC/RFT] mac80211: implement fq_codel for software queuing
Since 11n aggregation become important to get the
best out of txops. However aggregation inherently
requires buffering and queuing. Once variable
medium conditions to different associated stations
is considered it became apparent that bufferbloat
can't be simply fought with qdiscs for wireless
drivers. 11ac with MU-MIMO makes the problem
worse because the bandwidth-delay product becomes
even greater.
This bases on codel5 and sch_fq_codel.c. It may
not be the Right Thing yet but it should at least
provide a framework for more improvements.
I guess dropping rate could factor in per-station
rate control info but I don't know how this should
exactly be done. HW rate control drivers would
need extra work to take advantage of this.
This obviously works only with drivers that use
wake_tx_queue op.
Note: This uses IFF_NO_QUEUE to get rid of qdiscs
for wireless drivers that use mac80211 and
implement wake_tx_queue op.
Moreover the current txq_limit and latency setting
might need tweaking. Either from userspace or be
dynamically scaled with regard to, e.g. number of
associated stations.
FWIW This already works nicely with ath10k's (not
yey merged) pull-push congestion control for
MU-MIMO as far as throughput is concerned.
Evaluating latency improvements is a little tricky
at this point if a driver is using more queue
layering and/or its firmware controls tx
scheduling - hence I don't have any solid data on
this. I'm open for suggestions though.
It might also be a good idea to do the following
in the future:
- make generic tx scheduling which does some RR
over per-sta-tid queues and dequeues bursts of
packets to form a PPDU to fit into designated
txop timeframe and bytelimit
This could in theory be shared and used by
ath9k and (future) mt76.
Moreover tx scheduling could factor in rate
control info and keep per-station number of
queued packets at a sufficient low threshold to
avoid queue buildup for slow stations. Emmanuel
already did similar experiment for iwlwifi's
station mode and got promising results.
- make software queueing default internally in
mac80211. This could help other drivers to get
at least some benefit from mac80211 smarter
queueing.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
12 files changed
