cmm: Don't close CLI socket fd. libcli already did
cmm hands the file descriptor (fd) for the socket over which we receive
CLI commands to libcli by calling cli_loop(). The latter usually closes
the fd before it returns. There are a few unlikely out-of-memory
situations in which it doesn't, but we ignore those for now. When
cli_loop() returns, cmmCliThread() calls close() on the fd again! This
is bad because, in the meantime, the kernel might have re-assigned the
same fd to a completely unrelated socket. The second close() call from
cmmCliThread() could then erroneously close that unrelated socket.
Change-Id: I864fc6dfbb934f0426c0c8765e8a26c0c55fd81b
1 file changed