commit ad9a86c6fb1b602b280d798f1d77ec48511ebd79
author Avery Pennarun <apenwarr@gmail.com> Thu Jun 13 16:05:24 2013 -0400
committer Avery Pennarun <apenwarr@gmail.com> Thu Jun 13 16:05:24 2013 -0400
tree d9278a8da1112d84aceddc26d109455ffa90a601
parent 7e71ce2c13840f05422826a020da3956232f9f40
parent 158440f3fb9e9aa2d80f47a5b787b9074453f13c

Merge remote-tracking branch 'gfiber-internal/master' into merger

* gfiber-internal/master:
  HMX_NVRAM_SetField fix: check actual field size for skipping check.

libupgrade/hmx_upgrade_nvram.c

diff --git a/libupgrade/hmx_upgrade_nvram.c b/libupgrade/hmx_upgrade_nvram.c
index ecd198e..eb3ca59 100644
--- a/libupgrade/hmx_upgrade_nvram.c
+++ b/libupgrade/hmx_upgrade_nvram.c
@@ -871,9 +871,14 @@
     return DRV_ERR_OUTOFMEMORY;
   }
 
-  errCode = HMX_NVRAM_GetFieldAndSize(field, offset, pBuf, nDataSize, &pLen);
-  if (errCode == DRV_OK) {
-    if (memcmp(pBuf, data, nDataSize) == 0 && pLen == nDataSize) {
+  int fieldLen = 0;
+  // Need to use fieldLen for actual field length because pLen is always
+  // <= nDataSize. If input data size is shorter this may falsely skip hnvram
+  // writing.
+  if (HMX_NVRAM_GetLength(field, &fieldLen) == DRV_OK &&
+      HMX_NVRAM_GetFieldAndSize(field, offset, pBuf, nDataSize, &pLen)
+      == DRV_OK) {
+    if (memcmp(pBuf, data, nDataSize) == 0 && fieldLen == nDataSize) {
       free(pBuf);
       return DRV_OK;
     }