commit 1af92e2a211b0d46ef60ea9f30f989fd7b5725fa
author Yevgeny Petrilin <yevgenyp@mellanox.co.il> Sat Sep 05 20:24:49 2009 -0700
committer Roland Dreier <rolandd@cisco.com> Sat Sep 05 20:24:49 2009 -0700
tree ee52c5a1a7fc3e78b0bd1e4c317f98959b4b7ea7
parent fa0681d2129732027355d6b7083dd8932b9b799d

mlx4_core: Avoid double free_icms

On the error path of mlx4_init_hca(), mlx4_close_hca() is called,
followed by mlx4_free_icms() and mlx4_UNMAP_FA().  But both those
functions are also called from mlx4_close_hca(), which leads to a
double free.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

drivers/net/mlx4/main.c

diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 528f89b..3dd481e 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -789,7 +789,7 @@
 	return 0;
 
 err_close:
-	mlx4_close_hca(dev);
+	mlx4_CLOSE_HCA(dev, 0);
 
 err_free_icm:
 	mlx4_free_icms(dev);