| commit | 63a0d9d6fe42af8c97de12f23facc24fe76c0e84 | [log] [tgz] |
|---|---|---|
| author | Daniel Mentz <danielmentz@google.com> | Thu Jan 22 16:40:25 2015 -0800 |
| committer | Daniel Mentz <danielmentz@google.com> | Thu Jan 22 17:37:46 2015 -0800 |
| tree | 343e2ff1c2c2288add4ebb96e1dc04d2299a35d5 | |
| parent | 051b6390817095b9f407c1486e5f296ccdd08b4f [diff] |
Don't use GFP_KERNEL in netfilter hook (softirq) According to this email http://lists.netfilter.org/pipermail/netfilter-devel/2005-December/022720.html netfilter hooks might be called from softirq context. Therefore, we must not sleep and must avoid GFP_KERNEL. Call kmem_cache_alloc() with GFP_NOWAIT instead of GFP_KERNEL. We could use GFP_ATOMIC but that implies GFP_HIGH which might not be necessary here because it's acceptable for this call to fail. We previously saw this error message: "BUG: scheduling while atomic" Change-Id: I770ba9b82ba3a6f192b92c035383adb4d7c34e8d